internal/cmd: print correct config file on parse failure #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
requested changes
Oct 26, 2020
| @@ -63,18 +63,19 @@ func Generate(e Env, dir string, stderr io.Writer) (map[string]string, error) { | |||
| } | |||
|
|
|||
| if !yamlMissing && !jsonMissing { | |||
| fmt.Fprintln(stderr, "error parsing sqlc.json: both files present") | |||
| fmt.Fprintln(stderr, "error: both sqlc.json and sqlc.yaml files present") | |||
There was a problem hiding this comment.
This one doesn't have anything interpolated... ?
The one below this one should be Fprintf, I made a mistake there, but not this one
kevinburke1
force-pushed
the
error-names
branch
from
d07d594 to
8ac9959
Compare
|
Done |
kyleconroy
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.